Excel/Altering VBA

Advertisement


Question
Hi Tom

This piece of code that you wrote for me covers the range "A1:A40".  Could you show me how to alter the code so that it alters the range to "A1:A500"?

Thanks in advance

Chris M


Sub abcde()
Dim bk As Workbook, bk1 As Workbook
Dim sh As Worksheet
Dim r As Range, cell As Range
Dim sName As String

Set bk = ThisWorkbook
bk.SaveCopyAs Filename:="E:\Dummy.xlsm"
Set sh = bk.Worksheets("Createfiles")
Set r = sh.Range("A1", sh.Cells(41, "A").End(xlUp))
On Error GoTo ErrHandler
For Each cell In r
sName = ""
If Len(cell.Text) > 0 Then
  sName = cell.Text & ".xlsm"
  Workbooks.Open "E:\Dummy.xlsm"
  Set bk1 = ActiveWorkbook
  Debug.Print bk1.Name, sName
  bk1.SaveAs Filename:="E:\" & sName, _
    FileFormat:=xlOpenXMLWorkbookMacroEnabled
  bk1.Close SaveChanges:=False
End If
Next
Kill "E:\Dummy.xlsm"
Exit Sub
ErrHandler:
MsgBox "Error - problem with file: " & sName
Resume Next
End Sub

Answer
Christopher

Changed 41 to 501 where I have put in a comment '<====

Sub abcde()
Dim bk As Workbook, bk1 As Workbook
Dim sh As Worksheet
Dim r As Range, cell As Range
Dim sName As String

Set bk = ThisWorkbook
bk.SaveCopyAs Filename:="E:\Dummy.xlsm"
Set sh = bk.Worksheets("Createfiles")
Set r = sh.Range("A1", sh.Cells(501, "A").End(xlUp)) '<====
On Error GoTo ErrHandler
For Each cell In r
sName = ""
If Len(cell.Text) > 0 Then
  sName = cell.Text & ".xlsm"
  Workbooks.Open "E:\Dummy.xlsm"
  Set bk1 = ActiveWorkbook
  Debug.Print bk1.Name, sName
  bk1.SaveAs Filename:="E:\" & sName, _
    FileFormat:=xlOpenXMLWorkbookMacroEnabled
  bk1.Close SaveChanges:=False
End If
Next
Kill "E:\Dummy.xlsm"
Exit Sub
ErrHandler:
MsgBox "Error - problem with file: " & sName
Resume Next
End Sub

--
Regards,
Tom Ogilvy

About Excel
This topic answers questions related to Microsoft Excel spreadsheet (or workbook) stand-alone or Mircrosoft Office Excel including Excel 2003, Excel 2007, Office 2000, and Office XP. You can get Excel help on Excel formulas(or functions), Excell macros, charting in Excel, advanced features, and the general use of Excel. This does not provide a general Excel tutorial nor the basics of using a spreadsheet. It provides specific answers to using Microsoft Excel only. If you do not see your Excel question answered in this area then please ask an Excel question here

Excel

All Answers


Answers by Expert:


Ask Experts

Volunteer


Tom Ogilvy

Expertise

Selected as an Excel MVP by Microsoft since 1999. Answering Excel questions in Allexperts since its inception in 2001. Able to answer questions on almost all aspects of Excel's internal capabilities. If seeking a VBA solution, please specify that in your question itself so I give you the answer you want. [Excel has weak protection - if you are distributing an application, I don't answer questions on how to protect your project from your users.]

Experience

Extensive experience.

Education/Credentials
Master of Science (MS) degree Operations Research (ORSA)

Awards and Honors
Microsoft MVP in Excel.

©2016 About.com. All rights reserved.